[PATCH] target: kbuild: TCM_USER depends on UIO

[Andy Grover]

Also add more to help.

Signed-off-by: Andy Grover <***@redhat.com>
---
drivers/target/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/target/Kconfig b/drivers/target/Kconfig
index b03a845..e5ff37a 100644
--- a/drivers/target/Kconfig
+++ b/drivers/target/Kconfig
@@ -33,8 +33,10 @@ config TCM_PSCSI

config TCM_USER
tristate "TCM/USER Subsystem Plugin for Linux"
+ depends on UIO
help
- Say Y here to enable the TCM/USER subsystem plugin
+ Say Y here to enable the TCM/USER subsystem plugin for a userspace
+ process to handle requests

source "drivers/target/loopback/Kconfig"
source "drivers/target/tcm_fc/Kconfig"

[Randy Dunlap]

Post by Andy Grover
Also add more to help.

Ack the depends on, but it also needs to depend on NET to avoid these
build errors:

drivers/built-in.o: In function `tcmu_netlink_event':
target_core_user.c:(.text+0x9d4da): undefined reference to `__alloc_skb'
target_core_user.c:(.text+0x9d500): undefined reference to `genlmsg_put'
target_core_user.c:(.text+0x9d510): undefined reference to `kfree_skb'
target_core_user.c:(.text+0x9d534): undefined reference to `nla_put'
target_core_user.c:(.text+0x9d54e): undefined reference to `nla_put'
target_core_user.c:(.text+0x9d579): undefined reference to `kfree_skb'
target_core_user.c:(.text+0x9d591): undefined reference to `init_net'
target_core_user.c:(.text+0x9d5a4): undefined reference to `netlink_broadcast'
drivers/built-in.o: In function `tcmu_module_init':
target_core_user.c:(.init.text+0x431f): undefined reference to `__genl_register_family'
target_core_user.c:(.init.text+0x4345): undefined reference to `genl_unregister_family'
drivers/built-in.o: In function `tcmu_module_exit':
target_core_user.c:(.exit.text+0x984): undefined reference to `genl_unregister_family'

Post by Andy Grover
---
drivers/target/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/target/Kconfig b/drivers/target/Kconfig
index b03a845..e5ff37a 100644
--- a/drivers/target/Kconfig
+++ b/drivers/target/Kconfig
@@ -33,8 +33,10 @@ config TCM_PSCSI
config TCM_USER
tristate "TCM/USER Subsystem Plugin for Linux"
+ depends on UIO
help
- Say Y here to enable the TCM/USER subsystem plugin
+ Say Y here to enable the TCM/USER subsystem plugin for a userspace
+ process to handle requests
source "drivers/target/loopback/Kconfig"
source "drivers/target/tcm_fc/Kconfig"

[Nicholas A. Bellinger]

Post by Randy Dunlap

Post by Andy Grover
Also add more to help.

Ack the depends on, but it also needs to depend on NET to avoid these
target_core_user.c:(.text+0x9d4da): undefined reference to `__alloc_skb'
target_core_user.c:(.text+0x9d500): undefined reference to `genlmsg_put'
target_core_user.c:(.text+0x9d510): undefined reference to `kfree_skb'
target_core_user.c:(.text+0x9d534): undefined reference to `nla_put'
target_core_user.c:(.text+0x9d54e): undefined reference to `nla_put'
target_core_user.c:(.text+0x9d579): undefined reference to `kfree_skb'
target_core_user.c:(.text+0x9d591): undefined reference to `init_net'
target_core_user.c:(.text+0x9d5a4): undefined reference to `netlink_broadcast'
target_core_user.c:(.init.text+0x431f): undefined reference to `__genl_register_family'
target_core_user.c:(.init.text+0x4345): undefined reference to `genl_unregister_family'
target_core_user.c:(.exit.text+0x984): undefined reference to `genl_unregister_family'

Fixed. Thanks Randy!